Skip to content

Conversation

@spall
Copy link
Contributor

@spall spall commented Feb 7, 2025

Implement HLSLElementwiseCast excluding support for splat cases
Do not support casting types that contain bitfields.
Partly closes #100609 and partly closes #100619
Re-land #118842 after fixing warning as an error, found by a buildbot.

@spall spall changed the title [HLSL] Implement HLSL Elementwise casting (excluding splat cases); Re-land [HLSL] Implement HLSL Elementwise casting (excluding splat cases); Re-land #118842 Feb 7, 2025
Copy link
Contributor

@damyanp damyanp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as a reland.

@spall spall merged commit 3f8e280 into llvm:main Feb 7, 2025
10 checks passed
Icohedron pushed a commit to Icohedron/llvm-project that referenced this pull request Feb 11, 2025
…-land llvm#118842 (llvm#126258)

Implement HLSLElementwiseCast excluding support for splat cases
Do not support casting types that contain bitfields.
Partly closes llvm#100609 and
partly closes llvm#100619
Re-land llvm#118842 after fixing warning as an error, found by a buildbot.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[HLSL] Layout compatible type casting [HLSL] Array by-value casting

3 participants